-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Python and Go codegen runs in polymorph_code_gen
target
#688
base: main-1.x
Are you sure you want to change the base?
Conversation
@lucasmcdonald3 If you have the time, it would be great to also add Python to the
It should be straightforward to add the |
polymorph_code_gen
targetpolymorph_code_gen
and clean
targets
Putting this PR on ice until Go gets merged. This would create hiccups for Go that, ideally, we'd avoid for now. |
polymorph_code_gen
and clean
targetspolymorph_code_gen
target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but let's wait till we have Go fully merged and has CI, which should be this week.
polymorph_code_gen
targetpolymorph_code_gen
target
Keeping this unmerged until Go ESDK is released. |
Issue #, if available:
Description of changes: Python and Go run as part of
polymorph_code_gen
.Breaking change: The
dependency-library-name
CLI option has been removed. You must specify either/both of:python-dependency-module-name
go-dependency-module-name
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.