Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Python and Go codegen runs in polymorph_code_gen target #688

Open
wants to merge 29 commits into
base: main-1.x
Choose a base branch
from

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Nov 6, 2024

Issue #, if available:

Description of changes: Python and Go run as part of polymorph_code_gen.

Breaking change: The dependency-library-name CLI option has been removed. You must specify either/both of:

  • python-dependency-module-name
  • go-dependency-module-name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony
Copy link
Contributor

@lucasmcdonald3 If you have the time, it would be great to also add Python to the clean recipe.
For example, right now, when ever I need to re-polymorph the MPL, I run:

gmake clean;
rm -rf runtimes/python/src/aws_cryptographic_material_providers/smithygenerated

It should be straightforward to add the rm -rf of the Python Smithy generated to the Makefile.

@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review November 7, 2024 18:27
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner November 7, 2024 18:27
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Python codegen runs in polymorph_code_gen target chore: Python codegen runs in polymorph_code_gen and clean targets Nov 7, 2024
@lucasmcdonald3
Copy link
Contributor Author

Putting this PR on ice until Go gets merged.

This would create hiccups for Go that, ideally, we'd avoid for now.

@lucasmcdonald3 lucasmcdonald3 changed the title chore: Python codegen runs in polymorph_code_gen and clean targets chore: Python and Go codegen runs in polymorph_code_gen target Dec 16, 2024
Copy link
Contributor

@ShubhamChaturvedi7 ShubhamChaturvedi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but let's wait till we have Go fully merged and has CI, which should be this week.

@lucasmcdonald3 lucasmcdonald3 changed the title chore: Python and Go codegen runs in polymorph_code_gen target chore!: Python and Go codegen runs in polymorph_code_gen target Jan 7, 2025
@lucasmcdonald3
Copy link
Contributor Author

Keeping this unmerged until Go ESDK is released.
The breaking change to the Makefile variables would cause a hiccup for Go, and we'd prefer to keep that moving at full speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants