Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trim collection query param output values #764

Merged
merged 1 commit into from
May 18, 2023
Merged

Do not trim collection query param output values #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2623,14 +2623,18 @@ private String getCollectionOutputParam(
) {
MemberShape targetMember = target.getMember();
Shape collectionTarget = context.getModel().expectShape(targetMember.getTarget());
String collectionTargetValue = getOutputValue(context, bindingType, "_entry.trim()",
boolean trimParameterValue = bindingType != Location.QUERY && bindingType != Location.QUERY_PARAMS;
String outputValueDataSource = "_entry";
if (trimParameterValue) {
outputValueDataSource += ".trim()";
}
String collectionTargetValue = getOutputValue(context, bindingType, outputValueDataSource,
targetMember, collectionTarget);
String outputParam;
switch (bindingType) {
case QUERY_PARAMS:
case QUERY:
return String.format("%1$s.map(_entry => %2$s as any)",
dataSource, collectionTargetValue);
return String.format("%1$s.map(_entry => %2$s as any)", dataSource, collectionTargetValue);
case LABEL:
dataSource = "(" + dataSource + " || \"\")";
// Split these values on slashes.
Expand Down