Skip to content

Commit

Permalink
Add more test cases for enum member removal
Browse files Browse the repository at this point in the history
  • Loading branch information
JordonPhillips committed Oct 12, 2022
1 parent 2a17f71 commit 03aeefe
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ intEnum Bar {
@tags(["keep"])
@enumValue(2)
KEEP
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static org.hamcrest.Matchers.hasKey;
import static org.hamcrest.Matchers.not;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.util.ArrayList;
import java.util.Arrays;
Expand All @@ -34,7 +35,10 @@
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
import software.amazon.smithy.model.Model;
import software.amazon.smithy.model.SourceException;
import software.amazon.smithy.model.node.Node;
import software.amazon.smithy.model.shapes.EnumShape;
import software.amazon.smithy.model.shapes.IntEnumShape;
import software.amazon.smithy.model.shapes.ListShape;
import software.amazon.smithy.model.shapes.MapShape;
import software.amazon.smithy.model.shapes.MemberShape;
Expand Down Expand Up @@ -103,6 +107,56 @@ public void removesMapMembersWhenRemoved() {
assertContainerMembersAreRemoved(container, Arrays.asList(key, value));
}

@Test
public void removesEnumMembersWhenRemoved() {
EnumShape container = EnumShape.builder()
.id(ShapeId.from("ns.foo#Enum"))
.addMember("foo", "foo")
.build();
assertContainerMembersAreRemoved(container, new ArrayList<>(container.members()));
}

@Test
public void notAllEnumMembersCanBeRemoved() {
EnumShape container = EnumShape.builder()
.id(ShapeId.from("ns.foo#Enum"))
.addMember("foo", "foo")
.build();

Model.Builder builder = Model.builder()
.addShape(container)
.addShape(StringShape.builder().id(STRING_TARGET).build());
container.members().forEach(builder::addShape);
Model model = builder.build();
ModelTransformer transformer = ModelTransformer.create();
assertThrows(SourceException.class, () -> transformer.removeShapes(model, container.members()));
}

@Test
public void removesIntEnumMembersWhenRemoved() {
IntEnumShape container = IntEnumShape.builder()
.id(ShapeId.from("ns.foo#Enum"))
.addMember("foo", 1)
.build();
assertContainerMembersAreRemoved(container, new ArrayList<>(container.members()));
}

@Test
public void notAllIntEnumMembersCanBeRemoved() {
IntEnumShape container = IntEnumShape.builder()
.id(ShapeId.from("ns.foo#Enum"))
.addMember("foo", 1)
.build();

Model.Builder builder = Model.builder()
.addShape(container)
.addShape(StringShape.builder().id(STRING_TARGET).build());
container.members().forEach(builder::addShape);
Model model = builder.build();
ModelTransformer transformer = ModelTransformer.create();
assertThrows(SourceException.class, () -> transformer.removeShapes(model, container.members()));
}

@Test
public void removesStructureMembersWhenRemoved() {
MemberShape a = MemberShape.builder()
Expand Down

0 comments on commit 03aeefe

Please sign in to comment.