The awsJson protocols do not support jsonName trait

smithy-lang · Dec 23, 2021 · 331ab01 · 331ab01
1 parent b6bf60e
commit 331ab01
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/docs/source/1.0/spec/aws/aws-json.rst.template b/docs/source/1.0/spec/aws/aws-json.rst.template
@@ -18,10 +18,6 @@ that affect serialization:
     * - :ref:`hostLabel <hostLabel-trait>`
       - Binds a top-level operation input structure member to a label in
         the hostPrefix of an endpoint trait.
-    * - :ref:`jsonName <jsonName-trait>`
-      - By default, the JSON property names used in serialized structures are
-        the same as a structure member name. The ``jsonName`` trait changes
-        the JSON property name to a custom value.
     * - :ref:`timestampFormat <timestampFormat-trait>`
       - Defines a custom timestamp serialization format.
 

diff --git a/smithy-aws-protocol-tests/model/awsJson1_0/errors.smithy b/smithy-aws-protocol-tests/model/awsJson1_0/errors.smithy
@@ -68,7 +68,7 @@ structure ComplexError {
 }
 
 structure ComplexNestedErrorData {
-    @jsonName("Fooooo")
+    @jsonName("Fooooo") // Even if this trait it present, it does not affect serialization for this protocol
     Foo: String,
 }
 
@@ -92,7 +92,7 @@ apply ComplexError @httpResponseTests([
                   "__type": "aws.protocoltests.json10#ComplexError",
                   "TopLevel": "Top level",
                   "Nested": {
-                      "Fooooo": "bar"
+                      "Foo": "bar"
                   }
               }""",
         bodyMediaType: "application/json",

diff --git a/smithy-aws-protocol-tests/model/awsJson1_1/errors.smithy b/smithy-aws-protocol-tests/model/awsJson1_1/errors.smithy
@@ -61,7 +61,7 @@ structure ComplexError {
 }
 
 structure ComplexNestedErrorData {
-    @jsonName("Fooooo")
+    @jsonName("Fooooo") // Even if this trait it present, it does not affect serialization for this protocol
     Foo: String,
 }
 
@@ -85,7 +85,7 @@ apply ComplexError @httpResponseTests([
                   "__type": "ComplexError",
                   "TopLevel": "Top level",
                   "Nested": {
-                      "Fooooo": "bar"
+                      "Foo": "bar"
                   }
               }""",
         bodyMediaType: "application/json"

diff --git a/smithy-aws-protocol-tests/model/awsJson1_1/kitchen-sink.smithy b/smithy-aws-protocol-tests/model/awsJson1_1/kitchen-sink.smithy
@@ -464,14 +464,14 @@ use smithy.test#httpResponseTests
         id: "serializes_structure_members_with_locationname_traits",
         protocol: awsJson1_1,
         documentation: "Serializes structure members with locationName traits",
-        body: "{\"StructWithLocationName\":{\"RenamedMember\":\"some-value\"}}",
+        body: "{\"StructWithJsonName\":{\"Value\":\"some-value\"}}",
         bodyMediaType: "application/json",
         headers: {"Content-Type": "application/x-amz-json-1.1"},
         requireHeaders: [
             "Content-Length"
         ],
         params: {
-            StructWithLocationName: {
+            StructWithJsonName: {
                 Value: "some-value",
             },
         },
@@ -951,7 +951,7 @@ structure KitchenSink {
     RecursiveStruct: KitchenSink,
     SimpleStruct: SimpleStruct,
     String: String,
-    StructWithLocationName: StructWithLocationName,
+    StructWithJsonName: StructWithJsonName,
     Timestamp: Timestamp,
     @timestampFormat("epoch-seconds")
     UnixTimestamp: Timestamp,

diff --git a/smithy-aws-protocol-tests/model/awsJson1_1/main.smithy b/smithy-aws-protocol-tests/model/awsJson1_1/main.smithy
@@ -45,8 +45,8 @@ structure SimpleStruct {
     Value: String,
 }
 
-structure StructWithLocationName {
-    @jsonName("RenamedMember")
+structure StructWithJsonName {
+    @jsonName("RenamedMember") // Even if this trait it present, it does not affect serialization for this protocol
     Value: String,
 }