Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpMalformedRequestDefinition.getUri() returns Optional<String> #1102

Closed
david-perez opened this issue Feb 21, 2022 · 1 comment · Fixed by #1108
Closed

HttpMalformedRequestDefinition.getUri() returns Optional<String> #1102

david-perez opened this issue Feb 21, 2022 · 1 comment · Fixed by #1108

Comments

@david-perez
Copy link
Contributor

The spec says uri of HttpMalformedRequestDefinition is required.

However, HttpMalformedRequestDefinition.getUri() returns Optional<String>:

https://github.com/awslabs/smithy/blob/887ae4f6d118e55937105583a07deb90d8fabe1c/smithy-protocol-test-traits/src/main/java/software/amazon/smithy/protocoltests/traits/HttpMalformedRequestDefinition.java#L83-L85

This is in contrast to HttpRequestTestCase.getUri(), which returns String:

https://github.com/awslabs/smithy/blob/887ae4f6d118e55937105583a07deb90d8fabe1c/smithy-protocol-test-traits/src/main/java/software/amazon/smithy/protocoltests/traits/HttpRequestTestCase.java#L65-L67
JordonPhillips added a commit to JordonPhillips/smithy that referenced this issue Feb 25, 2022
@JordonPhillips
Add non-optional method for malformed request test uri
60291bb 
Resolves smithy-lang#1102
@JordonPhillips JordonPhillips mentioned this issue Feb 25, 2022
Merged
@JordonPhillips
Copy link
Contributor

Yep that's not great. Unfortunately we can't change the type signature, but I added a pr to introduce a new non-optional getter.

JordonPhillips added a commit that referenced this issue Feb 25, 2022
@JordonPhillips
Add non-optional method for malformed request test uri
fc1e890 
Resolves #1102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add non-optional method for malformed request test uri JordonPhillips/smithy
2 participants
@JordonPhillips @david-perez