-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading error message from incomplete model #743
Comments
The deprecated trait error is being emitted for the use of the The broken references, i.e. the missing shape, do result in some confusing errors. Ideally, no further validation would run after broken references are found, that'd eliminate the |
mtdowling
added a commit
that referenced
this issue
Apr 18, 2021
We previously would continue to perform more granular semantic model validation even after an ERROR was encountered while loading the model. If an ERROR is encountered while loading a model, then it is very likely that it can cause a flurry of unrelated validation events to emit errors that would only obscure the root cause of the issue. This commit updates model validation to stop if an ERROR occurred while loading models, if a model has broken shape references, if a shape target targets an invalid shape, or if a resource hierarchy is recursive. This update required various "kitchen-sink" style tests to be updated to account for the new validation behavior. Closes #743
mtdowling
added a commit
that referenced
this issue
Apr 19, 2021
We previously would continue to perform more granular semantic model validation even after an ERROR was encountered while loading the model. If an ERROR is encountered while loading a model, then it is very likely that it can cause a flurry of unrelated validation events to emit errors that would only obscure the root cause of the issue. This commit updates model validation to stop if an ERROR occurred while loading models, if a model has broken shape references, if a shape target targets an invalid shape, or if a resource hierarchy is recursive. This update required various "kitchen-sink" style tests to be updated to account for the new validation behavior. Closes #743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A model with
@xmlFlattened
attrubutes that is missing the referenced structure emits a "trait deprecated" error.Source model:
Expected error:
Actual Error:
Side note: when missing shapes are added there are no errors.
The text was updated successfully, but these errors were encountered: