Do not break models with dangerous set value types #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 937574b.
It's too big of a churn right now to actually break builds that use dangerous types with sets. This change leaves the documentation as-is, so the only way to use a set with a dangerous type is experimentation or having already done so.
gosar
reviewed
Mar 10, 2022
|
|
||
| Summary | ||
| Indicates that the items in a :ref:`list` MUST be unique. | ||
| Trait selector | ||
| ``:test(list > member > :test(string, blob, byte, short, integer, long, bigDecimal, bigInteger))`` | ||
| ``:test(list > member > simpleType)`` |
There was a problem hiding this comment.
why is this different than in the prelude?
There was a problem hiding this comment.
I straight up did a revert commit without even looking at the contents. I don't know.
There was a problem hiding this comment.
ah, so was incorrect before too. I'm fine with the revert commit, but maybe another commit to fix the documentation.
gosar
approved these changes
Mar 10, 2022
mtdowling
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.