-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning for API Gateway defaults #1916
Merged
srchase
merged 1 commit into
smithy-lang:main
from
srchase:remove-apigateway-defaulting
Aug 15, 2023
Merged
Add versioning for API Gateway defaults #1916
srchase
merged 1 commit into
smithy-lang:main
from
srchase:remove-apigateway-defaulting
Aug 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
force-pushed
the
remove-apigateway-defaulting
branch
from
August 11, 2023 20:32
984e1ba
to
9681f58
Compare
srchase
changed the title
Make disabling integer formats opt-in
Add versioning for API Gateway defaults
Aug 11, 2023
mtdowling
requested changes
Aug 11, 2023
...-openapi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/ApiGatewayDefaults.java
Show resolved
Hide resolved
...pi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultConfigSettings.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultConfigSettings.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
remove-apigateway-defaulting
branch
from
August 11, 2023 21:38
9681f58
to
5d15edf
Compare
mtdowling
requested changes
Aug 14, 2023
...y-openapi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/ApiGatewayDefault.java
Outdated
Show resolved
Hide resolved
...y-openapi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/ApiGatewayDefault.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultConfigSettings.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultConfigSettings.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
remove-apigateway-defaulting
branch
3 times, most recently
from
August 14, 2023 19:22
94dbad0
to
31cfe93
Compare
mtdowling
requested changes
Aug 14, 2023
...pi/src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddDefaultConfigSettings.java
Outdated
Show resolved
Hide resolved
srchase
force-pushed
the
remove-apigateway-defaulting
branch
2 times, most recently
from
August 14, 2023 22:05
234af66
to
5d05a9f
Compare
mtdowling
reviewed
Aug 15, 2023
@@ -1176,6 +1176,40 @@ dependency on ``software.amazon.smithy:smithy-aws-apigateway-openapi``. | |||
Amazon API Gateway configuration settings | |||
========================================= | |||
|
|||
apiGatewayDefault (``string``) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to pluralize this
mtdowling
approved these changes
Aug 15, 2023
srchase
force-pushed
the
remove-apigateway-defaulting
branch
from
August 15, 2023 16:21
5d05a9f
to
bb120e3
Compare
srchase
force-pushed
the
remove-apigateway-defaulting
branch
from
August 15, 2023 17:15
bb120e3
to
e42568a
Compare
alextwoods
pushed a commit
to alextwoods/smithy
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds versioning to manage API Gateway defaults.
By default, API Gateway conversions will use defaults of version
2023-08-11
which will set the following OpenAPI config options:All of these can be disabled by setting
apiGatewayDefaults
todisabled
in smithy-build.json:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.