Add docs and validation for endpoint patterns #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lEndpoints and standardPartitionalEndpoints
kstich
requested changes
Dec 13, 2023
...c/main/java/software/amazon/smithy/rulesengine/aws/validators/EndpointModifierValidator.java
Outdated
Show resolved
Hide resolved
| Matcher m = PATTERN.matcher(endpoint); | ||
| while (m.find()) { | ||
| if (!SUPPORTED_PATTERNS.contains(m.group())) { | ||
| events.add(danger( |
There was a problem hiding this comment.
Can these be aggregated to a list so that one event is emitted for an invalid endpoint pattern with any amount of unsupported labels in it?
There was a problem hiding this comment.
Yeah - will combine.
| ServiceShape serviceShape, StandardRegionalEndpointsTrait regionalEndpoints) { | ||
| List<ValidationEvent> events = new ArrayList<>(); | ||
|
|
||
| regionalEndpoints.getRegionSpecialCases().forEach((region, specialCases) -> { |
There was a problem hiding this comment.
Since region looks unused, you could iterate over the values() instead of the whole map.
for (RegionSpecialCase specialCase : regionalEndpoints.getRegionSpecialCases().values())
nit: also prefer for loops to forEach streaming iteration.
There was a problem hiding this comment.
This feedback applies to the Partitional branch as well, with the naming replaced.
|
|
||
| private List<ValidationEvent> validatePartitionalEndpointPatterns( | ||
| ServiceShape serviceShape, StandardPartitionalEndpointsTrait partitionalEndpoints) { | ||
|
|
kstich
requested changes
Dec 18, 2023
.../java/software/amazon/smithy/rulesengine/aws/validators/AwsSpecialCaseEndpointValidator.java
Show resolved
Hide resolved
kstich
requested changes
Dec 19, 2023
.../java/software/amazon/smithy/rulesengine/aws/validators/AwsSpecialCaseEndpointValidator.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/smithy/rulesengine/aws/validators/AwsSpecialCaseEndpointValidator.java
Outdated
Show resolved
Hide resolved
.../java/software/amazon/smithy/rulesengine/aws/validators/AwsSpecialCaseEndpointValidator.java
Outdated
Show resolved
Hide resolved
...mithy/rulesengine/aws/language/functions/errorfiles/invalid/invalid-endpoint-patterns.errors
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add docs and validation for endpoint patterns used by standardRegionalEndpoints and standardPartitionalEndpoints.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.