Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for aws.iam#serviceResolvedConditionKeys and aws.iam#conditionKeyValue #2287

Merged

Conversation

david-perez
Copy link
Contributor

Besides missing imports, aws.iam#conditionKeyValue was referring to an
undefined condition key.

Error if you build the current model:

Shape: smithy.example#OperationAInput$key
File:  /home/ANT.AMAZON.COM/davidpz/code/smithy-rs-main/codegen-server-test/../codegen-core/common-test-models/simple.smithy:22:9

19| @conditionKeys(["myservice:ActionContextKey1"])
20| operation OperationA {
21|     input := {
22|         @conditionKeyValue("ActionContextKey1")
  |         ^

This operation `smithy.example#OperationA` scoped within the
`smithy.example#MyService` service with member
`smithy.example#OperationAInput$key` refers to an undefined condition key
`ActionContextKey1`. Expected one of the following defined condition keys:
[`myservice:ActionContextKey1`]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…itionKeyValue`

Besides missing imports, `aws.iam#conditionKeyValue` was referring to an
undefined condition key.

Error if you build the current model:

```
Shape: smithy.example#OperationAInput$key
File:  /home/ANT.AMAZON.COM/davidpz/code/smithy-rs-main/codegen-server-test/../codegen-core/common-test-models/simple.smithy:22:9

19| @conditionKeys(["myservice:ActionContextKey1"])
20| operation OperationA {
21|     input := {
22|         @conditionKeyValue("ActionContextKey1")
  |         ^

This operation `smithy.example#OperationA` scoped within the
`smithy.example#MyService` service with member
`smithy.example#OperationAInput$key` refers to an undefined condition key
`ActionContextKey1`. Expected one of the following defined condition keys:
[`myservice:ActionContextKey1`]
```
@david-perez david-perez requested a review from a team as a code owner May 13, 2024 14:45
@david-perez david-perez requested a review from haydenbaker May 13, 2024 14:45
@david-perez
Copy link
Contributor Author

Would have been caught by #298.

@hpmellema hpmellema merged commit ae319f4 into smithy-lang:main May 14, 2024
13 checks passed
@david-perez david-perez deleted the davidpz/fix-condition-key-value-docs branch May 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants