Maps all unique content-types for operations and set passthroughBehavior to never in CORS preflight integration #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfkisafk
changed the title
|
Please lmk if this feature should be launched behind a feature flag in openapi settings or if I need to update the docs as well? |
…a new flag The new Open API setting is `syncCorsPreflightIntegration`. Added the docs as well. closes #2289
jfkisafk
changed the title
kstich
requested changes
May 22, 2024
smithy-model/src/main/java/software/amazon/smithy/model/node/ObjectNode.java
Outdated
Show resolved
Hide resolved
...src/main/java/software/amazon/smithy/aws/apigateway/openapi/AddCorsPreflightIntegration.java
Show resolved
Hide resolved
kstich
reviewed
May 22, 2024
docs/source-2.0/guides/model-translations/converting-to-openapi.rst
Outdated
Show resolved
Hide resolved
kstich
reviewed
May 22, 2024
docs/source-2.0/guides/model-translations/converting-to-openapi.rst
Outdated
Show resolved
Hide resolved
kstich
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
application/jsontemplate that is currently added.passthroughBehaviorfor the mock integration to "never" to fail-fast with 415 Unsupported in case a request is made with unsupported Content-Type.syncCorsPreflightIntegration(not sure about the name), which the service teams can turn on.application/json. This will pass the request to the actual GET/PUT/... method.Testing
./gradlew clean build.Links
when_no_matchpassthroughBehavior for@corspreflight integration in openapi definition #2289By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.