Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable multi variable expansion + tests #2495

Merged
merged 2 commits into from
Jan 7, 2025
Merged

enable multi variable expansion + tests #2495

merged 2 commits into from
Jan 7, 2025

Conversation

divmeh-aws
Copy link
Contributor

Background

  • What do these changes do?
  • When strings in config files have multiple environment variables, it reads and resolves each of them.
  • Why are they important?

Testing

  • How did you test these changes?
  • Added test to existing function - to resolve multiple variables.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@divmeh-aws divmeh-aws requested a review from a team as a code owner January 6, 2025 22:05
@divmeh-aws divmeh-aws requested a review from yefrig January 6, 2025 22:05
@divmeh-aws divmeh-aws merged commit b792363 into main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasmewad yasmewad yasmewad approved these changes

@mtdowling mtdowling mtdowling approved these changes

@yefrig yefrig Awaiting requested review from yefrig yefrig is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divmeh-aws @mtdowling @yasmewad