Implement fainted forme regression #10810
Open
+65
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the tests from the Revival Blessing file and kept only Terapagos's tests so that we can also verify if Terapagos-Terastal does not revert. The other tests are a bit redundant. |
pyuk-bot
reviewed
Jan 9, 2025
Co-authored-by: pyuk-bot <[email protected]>
|
I think Morpeko also needs special treatment to ensure it reverts to the correct forme after fainting while Terastallized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KrisXV I believe I have implemented your PR #9135 Closes #10025
I hard-coded regressions for Mega Evolutions, and Terastallized Ogerpon and Terapagos. I am not aware of any other Pokémon with this issue.
The first commit is just a simplification of the update of
details, while the second commit contains the logic for the regression. It's easier to review as separate commits.IMPORTANT: The client should not display the transform animation after the Pokémon faints. I added the [silent] flag, but I don’t think it’s necessary, as the animation occurs after the Pokémon leaves the screen (the client should be able to check this). Aside from that, the only other change is the Pokémon icon updating, which already happens.