Add Open at Login #188
Merged
Add Open at Login #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swyxio
reviewed
Aug 23, 2023
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| openAtLogin |
There was a problem hiding this comment.
can you add this in the dependency array please?
swyxio
requested changes
Aug 23, 2023
leeknowlton
force-pushed
the
openAtLogin
branch
from
8a127f2 to
e802cc1
Compare
|
This is my first public repo PR (at least first in a long time!). Not sure if notifications appear for new commits, but made the changes you mentioned. |
|
yes appreciated! i just needed some time since i was traveling this week |
|
tweaked wording, added to readme, added a lil image for reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response to #145