Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some missing log messages on task shutdown #1314

Merged
merged 1 commit into from
Nov 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion light-base/src/network_service/tasks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ pub(super) async fn single_stream_connection_task<TPlat: PlatformRef>(
let connection_task = connection_task.as_mut().unwrap_or_else(|| unreachable!());
connection_task.inject_coordinator_message(&platform.now(), message);
}
WhatHappened::CoordinatorDead => return,
WhatHappened::CoordinatorDead => {
log::trace!(target: "connections", "Connection({address_string}) => TaskShutdown");
return;
}
WhatHappened::SocketEvent => {}
WhatHappened::MessageSent => {}
}
Expand Down Expand Up @@ -368,6 +371,7 @@ pub(super) async fn webrtc_multi_stream_connection_task<TPlat: PlatformRef>(
)));
}
} else {
log::trace!(target: "connections", "Connection({address_string}) => TaskShutdown");
return;
}

Expand Down