Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.0 #70

Merged
merged 1 commit into from
Feb 18, 2024
Merged

v2.1.0 #70

merged 1 commit into from
Feb 18, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Feb 17, 2024

@taiki-e
Copy link
Collaborator

taiki-e commented Feb 18, 2024

Does smol-rs/event-listener#118 affect our use case? If so, it would be preferable to release it first and then release a new version specifying event-listener = "5.1" in Cargo.toml.
Otherwise, LGTM.

@taiki-e taiki-e mentioned this pull request Feb 18, 2024
@notgull
Copy link
Member Author

notgull commented Feb 18, 2024

Does smol-rs/event-listener#118 affect our use case? If so, it would be preferable to release it first and then release a new version specifying event-listener = "5.1" in Cargo.toml. Otherwise, LGTM.

Yes, see smol-rs/event-listener#120

notgull added a commit that referenced this pull request Feb 18, 2024
notgull added a commit to smol-rs/smol-macros that referenced this pull request Feb 18, 2024
notgull added a commit that referenced this pull request Feb 18, 2024
notgull added a commit to smol-rs/smol-macros that referenced this pull request Feb 18, 2024
Signed-off-by: John Nunley <[email protected]>
@notgull notgull merged commit ed17f53 into master Feb 18, 2024
14 checks passed
@notgull notgull deleted the notgull/next branch February 18, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants