v2.3.0 #95
Merged
v2.3.0 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM aside from CI failure (due to rustwasm/wasm-bindgen#4304). |
Signed-off-by: John Nunley <[email protected]>
Fixed via #96 |
|
Hmm, I guess it break compatibility with pre-1.51 rustc... like rust-lang/cargo#10954 |
|
What do you mean? We have 1.36 in the CI and it seems to pass. |
|
resolver is unknown field in 1.36, but unstable field in 1.50, so build will be fail in 1.50 even if pass in 1.36. |
|
(See also rust-lang/cargo#13505 (comment) for Cargo's behavior on unknown fields.) |
|
Hmm, is there a better solution to this? |
This comment was marked as outdated.
This comment was marked as outdated.
|
wasm-bindgen issue has been fixed in 0.2.98 (rustwasm/wasm-bindgen#4327), so just reverting #96 would be enough. |
taiki-e
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntoIteratorinchoose_multiplefunctions instead of justIterator. (Accept any IntoIterator in choose_multiple #92)