Allow overriding model_name #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinClowers
force-pushed
the
make-model-name-configurable
branch
2 times, most recently
from
7b77de9 to
6a321d5
Compare
smpallen99
reviewed
Mar 21, 2017
lib/ex_admin/helpers.ex
Outdated
| def model_name(%{__struct__: name}) do | ||
| model_name name | ||
| if has_function?(resource, :model_name, 0) do | ||
| resource.model_name |
There was a problem hiding this comment.
to avoid Elixir 1.4 warnings, I believe this should be resource.model_name()
|
I think a new section in the readme file would be the best way to document this. Please add that to the RP and I'll merge. |
This allows using different schemas for saving and loading data.
RobinClowers
force-pushed
the
make-model-name-configurable
branch
from
6a321d5 to
a2b21b3
Compare
|
@smpallen99 I addressed your feedback and rebased onto the latest master. Let me know if there is anything else. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using different schemas for saving and loading data. My specific use case is wanting a create form to have extra fields that get saved in associated records. For example, when I create an order in the database, I want to use the CreateOrder module, which also creates line items. For the most part you can do this by overriding the controller action, but when you have validation errors, you need to pass that changeset into the form builder, which then generates the form with the wrong path (/admin/create_orders rather than /admin/orders). I wasn't really sure where to document this, can you point me in the right direction?