Merge max-next into next #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework the parsing of the Snabb command line to allow us to ship a nicely named snabb-lwaftr binary, but have it map internally to the also nicely-named 'programs.lwaftr' module tree. Gets rid of the nasty "snabb" name duplication in the module tree.
This is intended to make Github match the ".md" suffix and treat the files as markdown format. This should enable better support in the web interface e.g. showing diffs with the rendered markdown. Link to relevant Github feature: https://help.github.com/articles/rendering-differences-in-prose-documents/
The syscall.util.if_nametoindex() only needs to be passed the name of the interface. The version of the function which accepts an open socket as second argument is internal to ljsyscall, and not even exported to client code. Also, this moves the call to syscall.util.if_nametoindex() to the top of RawSocket:new() to simplify error handling: this way one less explicit call to syscall.close() is needed in case of errors.
…nametoindex) into max-next
…) into max-next
|
By analyzing the blame information on this pull request, we identified @alexandergall, @lukego and @hb9cwp to be potential reviewers |
|
Merged! I would prefer to have shorter summary lines on the commits so that they don't get elided/truncated when browsing history. See the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains merges with #742 #743 #747.
Ping @lukego