Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RateLimitedRepeater to basic_apps #782

Closed
wants to merge 1 commit into from

Conversation

wingo
Copy link
Contributor

@wingo wingo commented Feb 25, 2016

This app is useful for generating different load levels. No documentation because the documentation files changed name in next and this is based on master, and the basic_apps documentation doesn't currently specify anything about the API of those applications, so documentation seems to be a moot point currently.

This app is useful for generating different load levels.
@eugeneia eugeneia self-assigned this Feb 25, 2016
@eugeneia
Copy link
Member

I think this is too fancy for apps.basic_apps and belongs under apps.test.*. What do you think @lukego?

@wingo
Copy link
Contributor Author

wingo commented Feb 26, 2016

Sure, or apps.rate_limiter; dunno. Or, perhaps we could add a mode to the RateLimiter that doesn't discard packets.

@wingo
Copy link
Contributor Author

wingo commented Feb 26, 2016

Somewhat related to the #656.

@eugeneia
Copy link
Member

@wingo I like the idea of extending RateLimiter and combining it with Repeater. It seems like a nice composing solution, but the choice is yours.

@mwiget
Copy link
Contributor

mwiget commented Feb 27, 2016

@wingo I like the idea as well. While one could chain a RateLimiter after the Repeater app, it burns avoidable CPU cycles by first creating the packets, then dropping them mid flight. Had to combine RateLimiter also in my crude snabb based lwaftr flow generator in order to have enough CPU cycles to count incoming traffic.

@wingo
Copy link
Contributor Author

wingo commented Mar 1, 2016

Closing this one; #793 is the successor.

@wingo wingo closed this Mar 1, 2016
@wingo wingo deleted the rate-limited-repeater branch March 1, 2016 15:01
dpino pushed a commit to dpino/snabb that referenced this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants