Skip to content

Commit

Permalink
[dynamo, test] remove skip for unhandled exception test (pytorch#123876)
Browse files Browse the repository at this point in the history
This test might no longer segfault in CI due to changes to how we allocate and free shadow frames in dynamo.

Pull Request resolved: pytorch#123876
Approved by: https://github.com/jansel
  • Loading branch information
williamwen42 authored and pytorchmergebot committed Apr 18, 2024
1 parent 812bae0 commit dca24d7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/dynamo/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -7052,7 +7052,6 @@ def f(a):
except RuntimeError as e:
self.assertIn("smoge", traceback.format_exc())

@unittest.skip("Not clear why this test would trigger a segfault.")
def test_unhandled_exception_in_dynamo2(self):
# segfaults in python 3.11 if shadow frame is freed improperly
from torch.testing import make_tensor
Expand Down

0 comments on commit dca24d7

Please sign in to comment.