init: add shared workflows and tools #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
lucyllewy
reviewed
Nov 30, 2023
This comment was marked as outdated.
This comment was marked as outdated.
merlijn-sebrechts
requested changes
Dec 1, 2023
There was a problem hiding this comment.
I think there's just one important change I'd like to see. Either move test-snap-build back into the snap repos, or include inputs so individual snaps can modify the behavior to allow things like classic snaps and permitted plugs/slots.
(these need to be specified, because the review action, by default, denies classic snaps and certain plugs and slots)
Nevertheless, it's really impressive work!!
Also adds an input to optionally install the snap on the runner after the build/review process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of actions and tools that can be shared across Snapcrafters repositories. This should cut down the amount of boilerplate in each repo, and give us one central place to update our CI actions. We can also version this repo if we choose.
Examples of how this will be used:
- snapcrafters/discord#168
- snapcrafters/signal-desktop#228
- snapcrafters/mattermost-desktop#93
- snapcrafters/snap-repo-template#40
Example runs from my testing repo:
The README has a good summary, and links to the other actions (and their READMEs).