Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: vote validation default value #834

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Fix: vote validation default value #834

merged 1 commit into from
Apr 5, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Apr 5, 2024

This one is a temporary fix for https://github.com/snapshot-labs/snapshot-sequencer/pull/325/files to return a default value when validation is {}

ideally, we will save

{
      name: 'any',
      params: {}
}

or null to this field

@ChaituVR ChaituVR requested a review from wa0x6e April 5, 2024 05:36
@ChaituVR ChaituVR enabled auto-merge (squash) April 5, 2024 05:37
wa0x6e
wa0x6e approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit 85e11c6 into master Apr 5, 2024
4 checks passed
@ChaituVR ChaituVR deleted the fix-vote-validation-default-value branch April 5, 2024 05:41
@wa0x6e
Copy link
Contributor

wa0x6e commented Apr 5, 2024

Can not save null to this field, as the schema does not permit null values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e