Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for network field in follows #847

Merged
merged 1 commit into from
May 22, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented May 2, 2024

Fixes snapshot-labs/snapshot-sequencer#341

This PR add support for the new network field added to follows in snapshot-labs/snapshot-sequencer#342

  • Add network and network_in filter to follows
  • Return the network field in follows

As we only have Space data for followed spaced of type s, all the spaces from other network will only return an id, with all other fields blank.

Tests

{
  follows(where: {network: "s"}, first: 10) {
   id
    space {
      id 
      name
      about
      turbo
      flagged
      verified
    }
    network
  }
}

@wa0x6e wa0x6e requested review from bonustrack and ChaituVR and removed request for bonustrack May 2, 2024 14:54
@wa0x6e wa0x6e self-assigned this May 2, 2024
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@wa0x6e wa0x6e merged commit 38170cb into master May 22, 2024
2 checks passed
@wa0x6e wa0x6e deleted the feat-add-network-to-follow branch May 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support follow for SX spaces
2 participants