fix: add new columns in schema.sql #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
changed the title
|
Any updates on this one ? Some tests are failing without this |
|
As far as I remember @bonustrack asked us to wait, but I'm not sure exactly. Do you think we can proceed? @bonustrack |
|
I've changed the new types on the |
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files📢 Thoughts on this report? Let us know! |
|
Updated |
ChaituVR
requested changes
Dec 2, 2024
ChaituVR
reviewed
Jan 7, 2025
| scores_total DECIMAL(64,30) NOT NULL, | ||
| scores_updated INT(11) NOT NULL, | ||
| scores_total_value DECIMAL(64,30) NOT NULL DEFAULT '0.000000000000000000000000000000', |
There was a problem hiding this comment.
why you pick this decimal value @bonustrack 😅
There was a problem hiding this comment.
I feel like this default size can increase our DB size no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #468
Updated schema.sql proposals to match with production database state
Added missing columns:
scores_total_valuevp_value_by_strategyAdded missing
DEFAULTto columns with defaultAdded missing INDEX
Added notes about some discrepancies with production database schema