Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync spaces custom domain with walletconnect allowed origins #487

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Jan 6, 2025

Closes #https://github.com/snapshot-labs/workflow/issues/362

This PR will sync the space's custom domain with WalletConnect allowed origins list, using walletconnect's new API

Changes

  • Adding a custom domain will also add on walletconnect
  • Removing a custom domain will remove it from walletconnect
  • Editing a custom domain will add the new one, and remove the old one from walletconnect

How to test

Set the new env vars in your .env

WALLETCONNECT_PROJECT_ID= # optional
REOWN_SECRET= # optional

You can create your own (via https://cloud.reown.com/app), or ask for the prod keys

  • Connect an UI (e.g sx or v1) to sequencer
  • On your terminal, send curl -X GET "https://cloud.reown.com/api/get-allowed-domains?projectId=[WALLETCONNECT_PROJECT_ID]" -H "Authorization: [REOWN_SECRET]" (set the correct variables)
  • It should return a list of whitelisted domains
  • On the UI, adds a new custom domain to your space
  • Send the curl command
  • The returned list should include your newly added domain
  • On the UI, update your space's custom domain
  • Send the curl command again
  • Your previous domain should be removed, and replaced by your updated one
  • On the UI, remove the custom domain from your space
  • Send the curl command again
  • Your domain should be removed from the list

@wa0x6e wa0x6e marked this pull request as ready for review January 6, 2025 21:44
@wa0x6e wa0x6e force-pushed the feat-whitelist-custom-domain-for-walletconnect branch from 6147398 to a00278c Compare January 6, 2025 21:50
@wa0x6e wa0x6e requested a review from ChaituVR January 6, 2025 21:50
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Jan 7, 2025

We currently have 1033 custom domain, and most of them are not working.

Should we import all of them, or import only those working ?

@wa0x6e wa0x6e requested a review from ChaituVR January 11, 2025 12:50
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Feb 24, 2025

What's stalling with this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants