feat: update space skins settings #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
force-pushed
the
feat-update-space-skin-settings
branch
from
179a761 to
53a1a2d
Compare
wa0x6e
force-pushed
the
feat-update-space-skin-settings
branch
from
53a1a2d to
88342aa
Compare
|
we handle these on #498 right? we can close this maybe? |
The other one is for adding a the custom logo only. The list of changed files will update once this one is merged into master |
ChaituVR
reviewed
Feb 6, 2025
ChaituVR
approved these changes
Feb 7, 2025
…snapshot-labs/snapshot-sequencer into feat-update-space-skin-settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/418
Depends on snapshot-labs/snapshot.js#1119
This PR will add support for updating the skins table when colors are passed in the space settings payload, only for whitelabel spaces
skinParamsis missing, will not do anything on the skinsWhen some skin properties are skipped, it will fallback to null, and will delete existing value