-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pendingTransactions with links #3768
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@j0hnfl0w any blockers with this PR? |
@bonustrack do you approve this design? Maybe instead of showing multiple IDs we should show a button "View transactions" that opens a modal with a list of pending and complete transactions |
The text in grey with blue background doesn't work well, I'd rather make it white, or use a modal. The modal would give much more space. |
@samuveth @bonustrack wdyt? |
I think we dont need the "Show more" button, we can just make the pending banner clickable and keep same height than before |
Unless they hover. How can someone assume the banner is clickable? I think maybe we should add some icon that suggests the banner is clickable or show "pending transactions" as a link |
Agree, there should be some indicator that transactions are viewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Nice work @j0hnfl0w |
Issues
Adds links to pending transactions.
Store pending transactions in localStorage with some TTL and waitForTransaction on page refresh.
Fixes #3141
Changes
How to test
To-Do
Self-review checklist
yarn cypress:test:e2e
, and they have passed