bug fix for 55c8d9b

snarfed · Oct 16, 2023 · 66cf3bf · 66cf3bf
1 parent 55c8d9b
commit 66cf3bf
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/models.py b/models.py
@@ -760,10 +760,11 @@ def get_or_create(cls, id, actor=None, **props):
             obj.new = False
             orig_as1 = obj.as1
             if orig_as1:
+                authors_actors = (as1.get_ids(orig_as1, 'author') +
+                                  as1.get_ids(orig_as1, 'actor'))
                 if not actor:
                     logger.warning(f'Cowardly refusing to overwrite {id} without checking actor')
-                elif actor not in (as1.get_ids(orig_as1, 'author') +
-                                   as1.get_ids(orig_as1, 'actor')):
+                elif actor not in authors_actors:
                     logger.warning(f"actor {actor} isn't {id}'s author or actor {authors_actors}")
         else:
             obj = Object(id=id)