Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop per-target delivery tracking #1501

Closed
snarfed opened this issue Nov 17, 2024 · 2 comments
Closed

Drop per-target delivery tracking #1501

snarfed opened this issue Nov 17, 2024 · 2 comments

Comments

@snarfed
Copy link
Owner

snarfed commented Nov 17, 2024

...ie Object.undelivered, sent, failed, etc. It's useful, but puts us over the 1MB datastore entity limit and breaks delivery for accounts with lots of followers, and it also generates a lot of datastore write load.

Same with Object.feed, I guess?

@snarfed
Copy link
Owner Author

snarfed commented Dec 15, 2024

Sigh. This got rid of a lot of our contention rollbacks (deployed at 12-14 ~10:00p PT, ie 3/4 of the way to the right in the top two graphs here):

image

...but it barely had any effect on our write load:

image

...and it didn't really even affect our contention failures:

https://console.cloud.google.com/errors/detail/CKbL5KSX98uZHw;time=P1D;locations=global?inv=1&invt=AbkNGg&project=bridgy-federated
image

https://console.cloud.google.com/errors/detail/CJm_4sDv9O-iKg;time=P1D;locations=global?inv=1&invt=AbkNGg&project=bridgy-federated
image

I may revert this. 🤷

@snarfed
Copy link
Owner Author

snarfed commented Dec 19, 2024

Leaving it for now.

@snarfed snarfed closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant