Make prefix/suffix interceptors for phpredis logging customizable #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
middleware
branch
6 times, most recently
from
cb98bca to
7328961
Compare
By inversing dependency for prefix/suffix closures and unifying it into something that looks more like an middleware, we are making interceptor customizable. One use case I can think of is building interceptor for APM agents - this way, we don't have to integrate such support inside this bundle, but 3rd party package can be created to facilitate such use cases.
ostrolucky
force-pushed
the
middleware
branch
from
7328961 to
b93bc7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By inversing dependency for prefix/suffix closures and unifying it into something that looks more like an middleware, we are making interceptor customizable. One use case I can think of is building interceptor for APM agents - this way, we don't have to integrate such support inside this bundle, but 3rd party package can be created to facilitate such use cases.