Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pages home aa1 to implement 1 #42

Merged
merged 7 commits into from
Jun 6, 2020
Merged

Add pages home aa1 to implement 1 #42

merged 7 commits into from
Jun 6, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 6, 2020 •
edited
Loading

The homepage component has been
added. The page is not routed yet.
Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

schettn added 3 commits June 6, 2020 19:51
@schettn
Add assets
05c3f16 
Some assets for the homepage has
been added.
@schettn
Add HomePage Component
19d1c91 
The homepage component has been
added. The page is not routed yet.
@schettn
Update package.json
4c9cef6 
react-typed package has been added.
@pinterid pinterid added the enhancement New feature or request label Jun 6, 2020
@pinterid pinterid added this to the SNEK Version 0.1.0 milestone Jun 6, 2020
@pinterid pinterid requested review from kleberbaum and schettn June 6, 2020 18:01
@pinterid pinterid self-assigned this Jun 6, 2020
@schettn schettn changed the base branch from master to implement-1 June 6, 2020 18:03
schettn
schettn approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pinterid
pinterid commented Jun 6, 2020
View reviewed changes
Copy link
Member Author

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

kleberbaum
kleberbaum approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@kleberbaum kleberbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok to merge.

pinterid and others added 4 commits June 6, 2020 20:36
@pinterid
Improve code quality
a836c18 
The code quality was improved due to request by Codacy.
@pinterid
Improve code quality
d36fea5 
The code quality was improved due to requests by Codacy.
@pinterid
Improve code quality
346489e 
The code quality was improved due to a request by Codacy.
@schettn
Merge branch 'implement-1' into add-pages-home-aa1
cc3384b
@schettn schettn merged commit 627e7bb into implement-1 Jun 6, 2020
@pinterid pinterid mentioned this pull request Jun 7, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleberbaum kleberbaum kleberbaum approved these changes

@schettn schettn schettn approved these changes

Assignees

@pinterid pinterid

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pinterid @kleberbaum @schettn