Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search aa1 to implement 1 #51

Merged
merged 5 commits into from
Jun 7, 2020
Merged

Add search aa1 to implement 1 #51

merged 5 commits into from
Jun 7, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 7, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

schettn added 3 commits June 7, 2020 03:11
@schettn
Add SearchBar Component
0768f6a 
A searchbar is created now. The searchbar
is added to the navbar now.
@schettn
Add getAllPageUrls
d3ba71b 
Now it is possible to fetch all snek users.
@schettn
Add fuzzysort for serach
ae7cd29 
Fuzzysort framework is used to
search in users.
@pinterid pinterid added the enhancement New feature or request label Jun 7, 2020
@pinterid pinterid added this to the SNEK Version 0.1.0 milestone Jun 7, 2020
@pinterid pinterid requested a review from schettn June 7, 2020 01:15
@pinterid pinterid self-assigned this Jun 7, 2020
pinterid
pinterid commented Jun 7, 2020
View reviewed changes
src/App.js Show resolved Hide resolved
pinterid
pinterid commented Jun 7, 2020
View reviewed changes
Copy link
Member Author

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after a change.

@pinterid
Improve code quality
30fd455 
The code quality was improved due to a request by @pinterid.
pinterid
pinterid commented Jun 7, 2020
View reviewed changes
Copy link
Member Author

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pinterid pinterid requested review from kleberbaum and removed request for kleberbaum June 7, 2020 01:48
schettn
schettn requested changes Jun 7, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion.

src/App.js Outdated Show resolved Hide resolved
@schettn
Apply suggestions from code review
4e146b6 
Suggestions of @schettn are applied now.
@pinterid pinterid requested a review from schettn June 7, 2020 02:01
schettn
schettn approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@schettn schettn merged commit 1afc181 into implement-1 Jun 7, 2020
@pinterid pinterid mentioned this pull request Jun 7, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettn schettn schettn approved these changes

Assignees

@pinterid pinterid

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pinterid @schettn