-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve basics aa2 to implement 1 #65
Conversation
The workaround for ghpages was implemented, it is now possible to reach sub-directories.
The authentication actions were added.
The general actions were added.
The user actions were added.
The talks actions were added.
The controlling actions were added.
The login handler was implemented.
The handler for logout was added.
The handler for registrations was added.
The handler for cache renewal was added.
The handler for fetching profiles was added.
The handler for talk uploads was added.
The handler for deleting talks was added.
The handler for saving settings was added.
The handler for controlling data were added.
Automatically login as a real or anonymous user on start.
The function access was updated to the new structure.
An unnecessary import was removed.
The wrong using of links in talks was removed.
The site no longer crashes if a user has no themes.
The talk upload modal structure was improved.
The login fail error was patched.
The code quality was improved due to a request by @kleberbaum.
The navbar links were updated from regular html to MDB Link.
And here we are. After three days of shit the routing issue is resolved and everything works like a charm. For the nerds: THE ISSUE WAS THE FUCKING HOMEPAGE PATH IN THE PACKAGE.JSON.. HOW THE FUCK COULD THIS HAPPEN???
Intel is changed to intel now.
The github oauth component is now received from a npm package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
♋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at my suggestions and remove all console logs which are not meant to used for troubleshooting.
For those troubleshooting logs add a TSID anchor and so on..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appearance stuff
The code quality has been improved due to a request of @schettn
The ferry has been renamed due to future implementations of ferry.
Useless logs are removed now. Some logs are changed to errors now.
The year was missing in some licence tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay nice
Checklist:
Type of Changes:
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (non-breaking change which adds documentation)
What is the current behavior? (link to any open issues here)
App.js
which produces a lot of mess. There is no folder structure for helpers #64What is the new behavior (if this is a feature change)?
App.js
only fulfils the purpose of setting main states. There is no folder structure for helpers #64Other information: