Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve basics aa2 to implement 1 #65

Merged
merged 47 commits into from
Jun 25, 2020
Merged

Improve basics aa2 to implement 1 #65

merged 47 commits into from
Jun 25, 2020

Conversation

pinterid
Copy link
Member

@pinterid pinterid commented Jun 16, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

  • Documentation (non-breaking change which adds documentation)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • Ref: 🐍

pinterid added 25 commits June 16, 2020 15:35
The workaround for ghpages was implemented, it is now possible to reach sub-directories.
The core for actions was added.
The authentication actions were added.
The general actions were added.
The user actions were added.
The talks actions were added.
The controlling actions were added.
The login handler was implemented.
The handler for logout was added.
The handler for registrations was added.
The handler for cache renewal was added.
The handler for fetching profiles was added.
The handler for talk uploads was added.
The handler for deleting talks was added.
The handler for saving settings was added.
The handler for controlling data were added.
Automatically login as a real or anonymous user on start.
The function access was updated to the new structure.
An unnecessary import was removed.
The wrong using of links in talks was removed.
The site no longer crashes if a user has no themes.
The talk upload modal structure was improved.
The login fail error was patched.
The code quality was improved due to a request by @kleberbaum.
The navbar links were updated from regular html to MDB Link.
@pinterid pinterid added the enhancement New feature or request label Jun 16, 2020
@pinterid pinterid requested a review from schettn June 16, 2020 14:29
@pinterid pinterid self-assigned this Jun 16, 2020
@pinterid pinterid requested review from kleberbaum and Aichnerc June 16, 2020 14:29
schettn and others added 3 commits June 24, 2020 21:59
And here we are. After three days of shit the routing issue is
resolved and everything works like a charm.
For the nerds:
THE ISSUE WAS THE FUCKING HOMEPAGE PATH IN THE
PACKAGE.JSON.. HOW THE FUCK COULD THIS HAPPEN???
Intel is changed to intel now.
The github oauth component is now received from a npm package.
@schettn schettn requested review from Aichnerc and schettn June 25, 2020 13:14
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at my suggestions and remove all console logs which are not meant to used for troubleshooting.
For those troubleshooting logs add a TSID anchor and so on..

package.json Outdated Show resolved Hide resolved
public/404.html Outdated Show resolved Hide resolved
public/404.html Outdated Show resolved Hide resolved
public/CNAME Outdated Show resolved Hide resolved
public/fav/manifest.json Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/components/molecules/forms/RegisterForm/index.jsx Outdated Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
Copy link
Member

@simonprast simonprast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appearance stuff

schettn added 4 commits June 25, 2020 15:57
The code quality has been improved due to a request of @schettn
The ferry has been renamed due to future implementations of
ferry.
Useless logs are removed now. Some logs are changed to errors
now.
The year was missing in some licence tags
@schettn schettn requested review from simonprast and schettn June 25, 2020 14:09
Copy link
Member

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@schettn schettn removed the request for review from kleberbaum June 25, 2020 14:10
Copy link
Member

@simonprast simonprast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay nice

@schettn schettn merged commit c6759fc into implement-1 Jun 25, 2020
@pinterid pinterid mentioned this pull request Jun 25, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no folder structure for helpers
4 participants