Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add movable aa1 to improve basics aa3 #89

Merged
merged 15 commits into from
Jul 8, 2020
Merged

Add movable aa1 to improve basics aa3 #89

merged 15 commits into from
Jul 8, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented Jul 8, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • 🐍

schettn added 11 commits July 7, 2020 10:10
@schettn
Add Movable Boundary
eef3053 
A boundary has been added which allows components to move within
a specified axis.
@schettn
Add Origin Check
060aa20 
A check which determines if the fetched and logged user matches.
@schettn
Integrate Movable in Overview Tab
b916bcd 
A editor mode has been added which allows movement for all relevant
components.
@schettn
Add Export for Error Boundary
67cd870 
The missing export for error boundary has been added.
@schettn
Improve Styling for Overview Tab
158a5c8 
The styling of sortable list and interchange charts has been improved.
@schettn
Improve Read Cache Action
0973e70 
The loading bar is disabled now because it interferes with the caching loading bar.
Now the user object is set every time a key is missing.
@schettn
Improve Write Cache Action
3ba02c2 
Now the platform data is stringified before cached.
@schettn
Implement Movable Pool Save Functionallity
789a6df 
Now when pressing the save button the pool gets stored in the platformData.
@schettn
Replace Local Storage Save with Pool
8211648 
Instead of local storage the indexArray is stored in a passed in object.
@schettn
Merge branch 'improve-basics-aa3' into add-movable-aa1
80e1305
@schettn
Improve Movable Boundary
dcfeca9 
Now the item order is saved on swapping
@schettn schettn added the enhancement New feature or request label Jul 8, 2020
@schettn schettn added this to the SNEK Version 0.1.0 milestone Jul 8, 2020
@schettn schettn changed the title Add movable aa1 to Add movable aa1 to improve basics aa3 Jul 8, 2020
schettn and others added 2 commits July 8, 2020 12:43
@schettn
Improve Code Quality
9b895a3 
The code quality has been improved due to codacy check.
@pinterid
Fix Codacy
6357341 
The issues marked by Codacy were resolved.
pinterid
pinterid requested changes Jul 8, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some mistakes.

src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/molecules/MovableBoundary/index.jsx Outdated Show resolved Hide resolved
src/components/organisms/tabs/OverviewTab/index.jsx Outdated Show resolved Hide resolved
src/components/organisms/tabs/OverviewTab/index.jsx Outdated Show resolved Hide resolved
src/components/organisms/tabs/OverviewTab/index.jsx Show resolved Hide resolved
src/components/organisms/tabs/OverviewTab/index.jsx Show resolved Hide resolved
pinterid and others added 2 commits July 8, 2020 13:06
@pinterid
Fix Codacy
f70bdbd 
Issues marked by Codacy were resolved.
@schettn
Improve code quality
abcae21 
The code quality has been improved due to a request of @pinterid.
@schettn schettn requested a review from pinterid July 8, 2020 11:36
pinterid
pinterid approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Aichnerc
Aichnerc approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕳

@schettn schettn removed the request for review from kleberbaum July 8, 2020 17:45
@schettn schettn merged commit d71bb28 into improve-basics-aa3 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aichnerc Aichnerc Aichnerc approved these changes

@pinterid pinterid pinterid approved these changes

Assignees

@Aichnerc Aichnerc

@Theralun Theralun

@schettn schettn

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@schettn @Aichnerc @pinterid @Theralun