Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve design ca1 to improve basics aa3 #91

Merged
merged 18 commits into from
Jul 8, 2020
Merged

Improve design ca1 to improve basics aa3 #91

merged 18 commits into from
Jul 8, 2020

Conversation

schettn
Copy link
Member

@schettn schettn commented Jul 8, 2020

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

What is the new behavior (if this is a feature change)?

Other information:

  • 🐍

Aichnerc and others added 14 commits July 7, 2020 20:35
@Aichnerc
Add scss to prettier
a24d8cf 
The SCSS file extension has been added to auto format for prettier.
@Aichnerc
Improve company page
582cfa5 
The chart points have been removed.
@Aichnerc
Add color variables
d30f511 
Some more color variables have been added to our SCSS config.
@Aichnerc
Improve design
4fe5507 
The general design of buttons and the profile page has been improved.
@Aichnerc
Fix Calendar3D
7eebc4a 
The code of the strike and contrib boxes has been greatly improved and does not longer suck. The design of those boxes has been improved. The max height of the chart bars has been reduced.
@Aichnerc
Improve Language chart
532224d 
There is now a grey chart if there is no language found.
@Aichnerc
Improve design
1308d04 
The design of buttons and pinned items has been improved.
@Aichnerc
Add profile button to main navbar
261c350 
The profile button has been moved.
@Aichnerc
Improve profile button on navbar
afa8237 
The padding has been adjusted.
@Aichnerc
Fix day and days seperation
f4f71fe 
The streaks are now marked as days or day.
@Aichnerc
Improve project cards
cabe83b 
The slash for owners has been replaced with an @.
@Aichnerc
Improve wording
8469dc0 
None has been replaced with Unknown in the project item.
@Aichnerc
Improve stability
0034279 
If there is no owner for a project, the new owner is unknown.
@schettn
Re-add loading bar styling
f20e71c 
The loading bar styling, which was previously accidentally removed, is now available
again. This will show the loading bar again.
@schettn schettn added the enhancement New feature or request label Jul 8, 2020
@schettn schettn added this to the SNEK Version 0.1.0 milestone Jul 8, 2020
@schettn schettn requested a review from Aichnerc July 8, 2020 18:10
@schettn schettn self-assigned this Jul 8, 2020
@schettn schettn requested a review from Theralun July 8, 2020 18:32
Theralun
Theralun approved these changes Jul 8, 2020
View reviewed changes
Copy link

@Theralun Theralun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beaut

@schettn
Improve code quality
d2d0e08 
Some scss stuff has been fixed due to a codacy request.
Aichnerc
Aichnerc approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@Aichnerc Aichnerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a console.log which could be problematic.

src/components/atoms/charts/LanguageBar/index.jsx Outdated Show resolved Hide resolved
@schettn @Aichnerc
Apply suggestions from code review
c01d1d6 
Co-authored-by: Aichner Christian <[email protected]>
@Aichnerc Aichnerc merged commit bfd64b3 into improve-basics-aa3 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Theralun Theralun Theralun approved these changes

@Aichnerc Aichnerc Aichnerc approved these changes

Assignees

@schettn schettn

Labels
enhancement New feature or request
Projects
None yet
Milestone
SNEK Version 0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@schettn @Aichnerc @Theralun