[SFP-Refactor]Fix vendor revision key issue (sonic-net#249)

* Fix vendor revision key issue * update sfp_base
snider-nokia · Dec 8, 2021 · 77da9c8 · 77da9c8
1 parent 94919de
commit 77da9c8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/sonic_platform_base/sfp_base.py b/sonic_platform_base/sfp_base.py
@@ -111,6 +111,7 @@ def get_transceiver_info(self):
         type                       |1*255VCHAR     |type of SFP
         type_abbrv_name            |1*255VCHAR     |type of SFP, abbreviated
         hardware_rev               |1*255VCHAR     |hardware version of SFP
+        vendor_rev                 |1*255VCHAR     |vendor revision of SFP
         serial                     |1*255VCHAR     |serial number of the SFP
         manufacturer               |1*255VCHAR     |SFP vendor name
         model                      |1*255VCHAR     |SFP model name

diff --git a/sonic_platform_base/sonic_xcvr/api/public/sff8436.py b/sonic_platform_base/sonic_xcvr/api/public/sff8436.py
@@ -48,7 +48,7 @@ def get_transceiver_info(self):
         xcvr_info = {
             "type": serial_id[consts.ID_FIELD],
             "type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
-            "hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
+            "vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
             "serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
             "manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
             "model": serial_id[consts.VENDOR_PART_NO_FIELD],

diff --git a/sonic_platform_base/sonic_xcvr/api/public/sff8472.py b/sonic_platform_base/sonic_xcvr/api/public/sff8472.py
@@ -41,7 +41,7 @@ def get_transceiver_info(self):
         xcvr_info = {
             "type": serial_id[consts.ID_FIELD],
             "type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
-            "hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
+            "vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
             "serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
             "manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
             "model": serial_id[consts.VENDOR_PART_NO_FIELD],

diff --git a/sonic_platform_base/sonic_xcvr/api/public/sff8636.py b/sonic_platform_base/sonic_xcvr/api/public/sff8636.py
@@ -55,7 +55,7 @@ def get_transceiver_info(self):
         xcvr_info = {
             "type": serial_id[consts.ID_FIELD],
             "type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
-            "hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
+            "vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
             "serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
             "manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
             "model": serial_id[consts.VENDOR_PART_NO_FIELD],