Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional details to the Lock activity #47

Merged
merged 2 commits into from
Mar 8, 2020

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Mar 7, 2020

  • Lock operation was remote

  • Lock operation was done via keypad

  • Lock operator image url

  • Lock operator thumbnail url

bdraco added 2 commits March 3, 2020 04:56
This adds support for working with the august api with async

The existing non-async support is left in-tact and it now shares
a common base module for Api and Authenticator to ensure
backwards compat.

When using async, the following changes need to be made in your
code

Api is now ApiAsync

  ApiAsync must be passed an aiohttp ClientSession()
  as the first argument

  await async_setup() must be called to setup the object
  after creating it

Authenticator is now AuthenticatorAsync

  AuthenticatorAsync must be passed an aiohttp ClientSession()
  as the first argument

  await async_setup_authentication() must be called to setup
  the object

AugustApiHTTPError is replaced with AugustApiAIOHTTPError

Checking for RequestException is replaced with checking for
ClientError

All of the async functions are prefixed with async_
Ex get_operable_locks is now async_get_operable_locks
* Lock operation was remote

* Lock operation was done via keypad

* Lock operation done by autorelock

* Lock operator image url

* Lock operator thumbnail url
@bdraco bdraco force-pushed the operation_details branch from bf096ae to d11777b Compare March 7, 2020 03:30
@snjoetw snjoetw merged commit 3556550 into snjoetw:master Mar 8, 2020
@snjoetw
Copy link
Owner

snjoetw commented Mar 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants