Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in converter.go, line 170 #132

Closed
murpheywa opened this issue Dec 12, 2017 · 2 comments · Fixed by #133
Closed

Bug in converter.go, line 170 #132

murpheywa opened this issue Dec 12, 2017 · 2 comments · Fixed by #133

Comments

@murpheywa
Copy link

Issue description

converter.go, line 170 should store a nil back into the "dest" pointer parameter. Instead it sets the pointer itself to nil.
The end result is a column value from the prior row gets passed to caller's next row if the next row's column value is nil.

Example code

Just change line 170 from

dest = nil

to

*dest = nil

Error log

N/A

Configuration

Both 1.1.0 and 1.1.1, any and all versions of golang and client OS's.

@smtakeda
Copy link
Contributor

Thanks for reporting a bug.. WIP

smtakeda added a commit that referenced this issue Dec 13, 2017
smtakeda added a commit that referenced this issue Dec 13, 2017
@smtakeda
Copy link
Contributor

The fix is merged with a test case. Get the latest code to have the fix for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants