fix a tz bug when validate ErrTooHighTimestampPrecision #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
reviewed
Feb 15, 2024
sfc-gh-pfus
approved these changes
Feb 18, 2024
|
@sfc-gh-pfus could you please re-trigger the tests? I think they might be flaky? |
|
Hi @Yifeng-Sigma, I rerun the tests and it seems that everything is passing. |
@sfc-gh-dheyman-1 Thank you! can we merge this? |
|
Thank you @Yifeng-Sigma for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We got error
268003 (22007): Cannot convert timestamp 2021-01-01 01:24:54 +0000 UTC in column Date to Arrow.Timestamp data type due to too high precision. Please use context with WithOriginalTimestamp.However this should be within the range that nanosecond supports.Notice that the date is the first day of the year, that points to where the problem is. The right side is always in UTC while the left side is from
arrowSnowflakeTimestampToTime()and can have a timezone.Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them