Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1856499 Retry HEAD requests to GCP #1274

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 11, 2024

Description

Fix for intermittent HEAD problems for GCP client on Windows.

@sfc-gh-pfus sfc-gh-pfus force-pushed the tmp-gcs-head-testing branch 5 times, most recently from c2d88a0 to ecb5dc9 Compare December 12, 2024 13:31
@sfc-gh-pfus sfc-gh-pfus changed the title Test GCS HEAD requests with retry NO-SNOW Separate GCS transport from the standard one Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (80c18ea) to head (324f57a).

Files with missing lines Patch % Lines
gcs_storage_client.go 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1274      +/-   ##
==========================================
- Coverage   82.23%   82.23%   -0.01%     
==========================================
  Files          55       55              
  Lines       13569    13574       +5     
==========================================
+ Hits        11159    11163       +4     
- Misses       2410     2411       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 13, 2024 10:53
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 13, 2024 10:53
@sfc-gh-pfus sfc-gh-pfus changed the title NO-SNOW Separate GCS transport from the standard one SNOW-1856499 Separate GCS transport from the standard one Dec 13, 2024
@sfc-gh-pfus sfc-gh-pfus changed the title SNOW-1856499 Separate GCS transport from the standard one SNOW-1856499 Retry HEAD requests to GCP Jan 15, 2025
@sfc-gh-pfus sfc-gh-pfus enabled auto-merge (squash) January 15, 2025 13:33
@sfc-gh-pfus sfc-gh-pfus merged commit b0cd681 into master Jan 16, 2025
38 of 39 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the tmp-gcs-head-testing branch January 16, 2025 06:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants