Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-692945: refactoring for resultset C wrapper #724

Merged
merged 14 commits into from
Oct 18, 2024

Conversation

SimbaGithub
Copy link
Collaborator

Preparing for adding multiple statements support, refactoring on the resultset C wrapper. Remove unnecessary code and make it more cleaner for adding new feature.

@SimbaGithub SimbaGithub requested a review from a team as a code owner May 31, 2024 16:29
@SimbaGithub SimbaGithub force-pushed the SNOW-1371086-multiple-statements branch from 52a9e80 to 0c5b00a Compare May 31, 2024 17:30
@SimbaGithub SimbaGithub force-pushed the SNOW-1371086-multiple-statements branch from 0c5b00a to a6b3a3e Compare June 13, 2024 17:18
cpp/lib/ResultSetArrow.cpp Outdated Show resolved Hide resolved
cpp/lib/result_set.cpp Outdated Show resolved Hide resolved
include/snowflake/client.h Outdated Show resolved Hide resolved
include/snowflake/client.h Outdated Show resolved Hide resolved
include/snowflake/client.h Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx force-pushed the SNOW-1371086-multiple-statements branch from a6b3a3e to 3f2906d Compare July 29, 2024 16:55
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx changed the title SNOW-1371086: refactoring for resultset C wrapper SNOW-692945: refactoring for resultset C wrapper Aug 1, 2024
@sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-dstempniak Please help to check what's the failure with continuous-integration/jenkins/pr-head

@sfc-gh-dstempniak
Copy link
Contributor

@sfc-gh-ext-simba-hx One test failed on Macaarch64:

2024-09-05 00:02:15 56: [ RUN      ] test_simple_put_use_dev_urandom
2024-09-05 00:02:15 56: [  ERROR   ] --- Test failed with exception: Segmentation fault: 11(11)
2024-09-05 00:02:15 56: [  FAILED  ] test_simple_put_use_dev_urandom

After rerun it succeeded:

2024-09-05 12:21:30 56: [ RUN      ] test_simple_put_use_dev_urandom
2024-09-05 12:21:34 56: [       OK ] test_simple_put_use_dev_urandom

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx changed the base branch from master to master-2.0.0 October 3, 2024 16:46
cpp/lib/result_set.cpp Outdated Show resolved Hide resolved
cpp/lib/result_set.cpp Outdated Show resolved Hide resolved
cpp/lib/result_set.cpp Outdated Show resolved Hide resolved
cpp/lib/result_set.cpp Outdated Show resolved Hide resolved
@sfc-gh-ext-simba-hx
Copy link
Collaborator

@sfc-gh-dprzybysz
Please help to check what's the failure with continuous-integration/jenkins/pr-head ?

@sfc-gh-jszczerbinski
Copy link
Collaborator

sfc-gh-jszczerbinski commented Oct 17, 2024

Linker error during building libsnowflakeclient on Linux-aarch64:

2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o): In function `arrow::Field::MergeOptions::ToString[abi:cxx11]() const':
2024-10-16 18:40:55  type.cc:(.text+0x4d74): undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()'
2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o): In function `arrow::Field::ToString[abi:cxx11](bool) const':
2024-10-16 18:40:55  type.cc:(.text+0x5144): undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()'
2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o): In function `arrow::TypeHolder::ToString[abi:cxx11](std::vector<arrow::TypeHolder, std::allocator<arrow::TypeHolder> > const&)':
2024-10-16 18:40:55  type.cc:(.text+0x541c): undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()'
2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o): In function `arrow::ListType::ToString[abi:cxx11]() const':
2024-10-16 18:40:55  type.cc:(.text+0x56d4): undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()'
2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o): In function `arrow::LargeListType::ToString[abi:cxx11]() const':
2024-10-16 18:40:55  type.cc:(.text+0x58f4): undefined reference to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()'
2024-10-16 18:40:55  /mnt/host/deps-build/linux/Release/arrow/lib64/libarrow.a(type.cc.o):type.cc:(.text+0x5b14): more undefined references to `std::__cxx11::basic_stringstream<char, std::char_traits<char>, std::allocator<char> >::basic_stringstream()' follow

Seems like a weird error, consider rebasing - maybe it will go away

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx merged commit 6bc1b92 into master-2.0.0 Oct 18, 2024
41 checks passed
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx deleted the SNOW-1371086-multiple-statements branch October 18, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants