Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1308317 SNOW-1432770 Update DatabaseMetaDataInternalIT testGetTables to work with adding account_usage_snowhouse_local_setup_import.sql to make setup #1760

Merged
merged 2 commits into from
May 20, 2024

Conversation

sfc-gh-ntrinh
Copy link
Collaborator

@sfc-gh-ntrinh sfc-gh-ntrinh commented May 16, 2024

Overview

SNOW-1432770 Update DatabaseMetaDataInternalIT testGetTables to work with adding account_usage_snowhouse_local_setup_import.sql to make setup. See JIRA for details.

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

…bles to work with adding account_usage_snowhouse_local_setup_import.sql to make setup
@sfc-gh-ntrinh sfc-gh-ntrinh marked this pull request as ready for review May 17, 2024 01:14
@sfc-gh-ntrinh sfc-gh-ntrinh requested a review from a team as a code owner May 17, 2024 01:14
@sfc-gh-ntrinh sfc-gh-ntrinh merged commit 23db457 into master May 20, 2024
35 of 37 checks passed
@sfc-gh-ntrinh sfc-gh-ntrinh deleted the ntrinh/gettables branch May 20, 2024 16:07
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants