Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1867961: Fix from_json not working the TimestampType that contains tzinfo #2825

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1867961

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR fixes a bug in _parse_datatype_json_value that failed to parse timestamp types that had timezone information. Previously the type strings for timestamp_ntz, timestamp_ltz, and timestamp_tz were not recognized as valid timezone types.

@sfc-gh-jrose sfc-gh-jrose merged commit f90ba59 into main Jan 7, 2025
40 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1867961_struct_from_json_tz branch January 7, 2025 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants