Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Clean up remaining bits related to ghc-cabal #658

Merged
merged 11 commits into from
Aug 26, 2018
Merged

Conversation

snowleopard
Copy link
Owner

After merging #531, we still have a few occurrences of the ghc-cabal package, as well as the GhcCabal builder, which we need to clean up. See #635.

@snowleopard
Copy link
Owner Author

@alpmestan @angerman @chitrak7 I think I found a good way to merge GhcCabal and CabalFlags. I replaced them with a new builder Cabal with ConfigurationInfo = Setup | Flags to distinguish between the two pieces of information -- see the latest commit. Any comments/suggestions?

@angerman
Copy link
Collaborator

Look good. I’m still stumbling over the Setup name though; can’t think of a better name right now though. Something along the line of SetupHsArgs might be more descriptive.

@snowleopard
Copy link
Owner Author

@angerman Thanks! Yes, I might rename Setup to something more descriptive -- it's not used a lot, so there is not a lot of gain from using a short name.

By the way, could you clarify the purpose of GhcPkg Dependencies builder? It is used in copyConf to extract dependencies from a .conf file, but I don't understand how this is different from other available dependency extraction mechanisms, e.g. we have PackageData.dependencies and PackageData.depIpIds.

@snowleopard snowleopard changed the title [WIP] Clean up remaining bits related to ghc-cabal Clean up remaining bits related to ghc-cabal Aug 26, 2018
@snowleopard snowleopard merged commit 8dc4f73 into master Aug 26, 2018
@snowleopard snowleopard deleted the drop-ghc-cabal branch August 26, 2018 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants