Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 #744

Closed
BenFradet opened this issue Mar 22, 2018 · 3 comments
Closed

Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 #744

BenFradet opened this issue Mar 22, 2018 · 3 comments
Assignees
@BenFradet
Milestone
Release 89

Comments

@BenFradet
Copy link
Contributor

isp and org are now contained in the same file and file names have changed.

Also I wonder if it makes sense to make at least geo required?
@BenFradet BenFradet self-assigned this Mar 22, 2018
@alexanderdean
Copy link
Member

Sounds good. Is geo truly required? Couldn't you just run the other lookups?

@BenFradet
Copy link
Contributor Author

Not really, the problem is that it's a valid enrichment not to have any databases.

Also it makes the API in maxmind-ip-lookups a bit clunky since everything is optional.

@alexanderdean
Copy link
Member

I don't think we can assume which of the databases the user wants to use.

BenFradet added a commit that referenced this issue Mar 28, 2018
@BenFradet
Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 (closes …
bafbb1d 
…#744)
BenFradet added a commit that referenced this issue Apr 2, 2018
@BenFradet
Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 (closes …
084d36c 
…#744)
@BenFradet BenFradet added this to the Release 89 milestone Apr 6, 2018
BenFradet added a commit that referenced this issue Apr 6, 2018
@BenFradet
Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 (closes …
93fe781 
…#744)
BenFradet added a commit that referenced this issue Apr 6, 2018
@BenFradet
Add com.snowplowanalytics.snowplow/ip_lookups/jsonschema/2-0-0 (closes …
269081c 
…#744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenFradet BenFradet

Labels
None yet
Projects
None yet
Milestone
Release 89
Development

No branches or pull requests
2 participants
@alexanderdean @BenFradet