Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix eid and dtm being incorrectly added to screen_view and timing context #163

Closed
jbeemster opened this issue Sep 4, 2015 · 2 comments
Closed

Core: Fix eid and dtm being incorrectly added to screen_view and timing context #163

jbeemster opened this issue Sep 4, 2015 · 2 comments
Assignees
@jbeemster
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
Version 0.5.1

Comments

@jbeemster
Copy link
Member

The DTM and EID fields are currently being added inside the context by accident.
@jbeemster jbeemster added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Sep 4, 2015
@jbeemster jbeemster self-assigned this Sep 4, 2015
@jbeemster jbeemster added this to the Version 0.6.0 milestone Sep 4, 2015
@jbeemster jbeemster changed the title Fix eid being incorrectly added to screen_view and timing context Fix eid and dtm being incorrectly added to screen_view and timing context Sep 4, 2015
@alexanderdean
Copy link
Member

What's the impact of this bug on users?
On 4 Sep 2015 8:53 am, "Josh" [email protected] wrote:

The EID is currently being added inside the context by accident.

—
Reply to this email directly or view it on GitHub
#163.

@jbeemster
Copy link
Member Author

I believe Screen Views and Timings wont be able to be validated. I was going to a 0.5.1 bug fix for this as its a pretty bad one.

@jbeemster jbeemster modified the milestones: Version 0.5.1, Version 0.6.0 Sep 4, 2015
@jbeemster jbeemster changed the title Fix eid and dtm being incorrectly added to screen_view and timing context Core: Fix eid and dtm being incorrectly added to screen_view and timing context Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbeemster jbeemster

Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
Version 0.5.1
Development

No branches or pull requests
2 participants
@alexanderdean @jbeemster