Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertising ID retrieval creates new thread #50

Closed
alexanderdean opened this issue Jan 2, 2015 · 1 comment
Closed

Advertising ID retrieval creates new thread #50

alexanderdean opened this issue Jan 2, 2015 · 1 comment
Assignees
@jbeemster
Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Milestone
Version 0.3.0

Comments

@alexanderdean
Copy link
Member

Advertising ID is obtained by creating a new thread, which is considered very bad practice.

Raised by @hamidp
@alexanderdean alexanderdean added the type:defect Bugs or weaknesses. The issue has to contain steps to reproduce. label Jan 2, 2015
@alexanderdean alexanderdean added this to the Version 0.3.0 milestone Jan 2, 2015
@alexanderdean alexanderdean mentioned this issue Jan 14, 2015
Closed
@jbeemster
Copy link
Member

The advertising id fetch has been changed based on trello/snowmans implementation:
https://github.com/trello/snowman/blob/master/library/src/main/java/com/trello/snowman/SnowmanUtil.java#L65-L80

Our implementation:
https://github.com/snowplow/snowplow-android-tracker/blob/develop/snowplow-android-tracker/src/main/java/com/snowplowanalytics/snowplow/tracker/Subject.java#L187-L196

@jbeemster jbeemster reopened this Feb 9, 2015
jbeemster added a commit that referenced this issue Feb 9, 2015
@jbeemster
Advertising ID retrieval creates new thread (fixes #50)
905a9c3 
- Also added some extra comments to Subject Functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbeemster jbeemster

Labels
type:defect Bugs or weaknesses. The issue has to contain steps to reproduce.
Projects
None yet
Milestone
Version 0.3.0
Development

No branches or pull requests
3 participants
@alexanderdean @jonalmeida @jbeemster