Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default emit timeout from 5 seconds to 30 seconds #658

Closed
matus-tomlein opened this issue Jan 18, 2024 · 0 comments
Closed

Change default emit timeout from 5 seconds to 30 seconds #658

matus-tomlein opened this issue Jan 18, 2024 · 0 comments
Labels
status:completed Completed - but might not be released yet.
Milestone

Comments

@matus-tomlein
Copy link
Contributor

Currently, there is an enforced emit timeout in the OkHttpNetworkConnection that defaults to 5 seconds after which it cancels the requests.

5 seconds is unlikely to be enough in many cases – slower cellular connections, switching between wifi and cellular. It can lead to requests being cancelled too early and resent again. This can then cause duplicates in the warehouse. On iOS, we use the default 60 seconds timeout (not configurable).

I suggest changing the default to 30 seconds. 30s would fit the currently set 15 seconds connection and 15 seconds read timeout, set here.

@mscwilson mscwilson added the status:completed Completed - but might not be released yet. label Jan 26, 2024
@mscwilson mscwilson mentioned this issue Feb 1, 2024
@matus-tomlein matus-tomlein added this to the 6.0.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:completed Completed - but might not be released yet.
Projects
None yet
Development

No branches or pull requests

2 participants