Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach different entity in demo global context (close #514) #515

Merged
merged 1 commit into from
May 23, 2022

Conversation

mscwilson
Copy link
Contributor

For issue #514.
Two copies of the Application entity were being added to events generated by the demo. This turned out to be because applicationContext was turned on, but the same entity (and data) was being used to demonstrate global context.

This change uses a different schema for the global contexts example.

@mscwilson mscwilson requested a review from AlexBenny May 3, 2022 09:50
@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label May 3, 2022
@snowplow snowplow deleted a comment from snowplowcla May 3, 2022
@mscwilson mscwilson removed the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label May 3, 2022
Copy link
Contributor

@AlexBenny AlexBenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 👍 Now it's much better.

@mscwilson mscwilson changed the base branch from release/3.1.4 to release/3.1.2 May 23, 2022 13:04
@mscwilson mscwilson merged commit 63fbf28 into release/3.1.2 May 23, 2022
@mscwilson mscwilson deleted the issue/514-duplicate_entity branch May 23, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants